Repository navigation
ci: give the test job 60 minutes - #457
Merged
Merged
Conversation
There was a problem hiding this comment.
🔵 Needs a closer look
No code issues were identified, but successful completion of the required CI checks under the revised timeout remains unconfirmed.
No open issues 🎉
What changed in this PR
Raises the main CI test job’s timeout to give Python 3.12 coverage runs more headroom, addressing the cancellations reported in #454.
Changes:
- Increase the
testjob timeout from 45 to 60 minutes; Windows remains at 45 minutes. - Update the timeout regression test and document the new deadline range.
| File | Description |
|---|---|
tests/test_ci_workflow.py |
Pin the test job timeout to 60 minutes and explain the measured runtime. |
docs/dev/quality-gates.md |
Update the documented deadline range to 10–60 minutes. |
.github/workflows/ci.yml |
Set the test matrix’s timeout to 60 minutes. |
Review effort: Balanced
Owner
Author
|
This PR's own |
The test job runs the full suite under coverage after lint and type checks, all within 45 minutes. On Python 3.12 that took 39-46 minutes: in the last 25 CI runs the 3.12 job took 43 minutes or more ten times, and it was cut off at the limit with no failures on 9793c5c, on #446's 3dce28c (twice, at 99%), and on main at 0648d1b (at 93%, on korvid-runners). A cancelled required check blocks a pull request until someone reruns it, which an outside contributor cannot do. Raise the limit to 60 minutes and update the pinned value and the quality-gates note. Windows keeps 45; it finishes in about 30. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
hellices
force-pushed
the
fix/454-test-timeout
branch
from
October 23, 2026 02:47
753a033 to
b3d9b80
Compare
Regenerated by the Relock workflow, which runs on a runner with direct PyPI access. Locking is not possible from a machine behind a TLS-intercepting mirror: the resulting lock names the mirror, and the repository rejects that. (cherry picked from commit c5e3a4e)
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #454
Closes #463
Summary
The
testjob runs lint, type checks, and the full suite under coverage, all withintimeout-minutes: 45. On Python 3.12 the job takes 39–46 minutes. In the last 25 CI runs, 3.12 took 43 minutes or more ten times. It was cut off at the limit with no test failures on:mainat 0648d1b, at 93%, onkorvid-runners.A cancelled required check blocks a pull request until someone reruns it, and an outside contributor cannot rerun it.
This PR raises the
testjob to 60 minutes and updates the pinned value intests/test_ci_workflow.py. It also updates the "10–45 minute" range indocs/dev/quality-gates.mdto 10–60.windows-teststays at 45 minutes because it finishes in about 30.docs/superpowers/specs/2026-09-11-repository-stabilization-design.mdstill says 45 minutes. That is the dated design record of the original sizing ("sized above measured healthy durations"), so this PR leaves it as written. This change applies the same rule to newer measurements.It also carries
build: relock opentelemetry-apifor #463, cherry-picked from the Relock workflow'srelock/20261023-033350(run 39892989114). Since 2026-10-22 the requiredsecuritycheck fails on every branch:pip-auditreports GHSA-xcq7-p3pf-p88h (CVE-2026-114603) against the locked opentelemetry-api 1.44.0. The relock moves only that package to 1.45.1, souv.lockchanges by three lines and still resolves from PyPI only.Verification
tests/test_ci_workflow.py::test_ci_jobs_have_explicit_bounded_timeoutspins every job's timeout. Settingci.ymlback to 45 while the pin says 60 makes it fail; restoring 60 makes it pass.Run locally on macOS with Python 3.13 and the frozen lock.
make checkruns each step throughuv run, which in a fresh worktree tries to sync from PyPI that this machine cannot reach, so each step ran directly with the project's environment:pytest -p no:tach tests/test_ci_workflow.py tests/test_docs_links.py tests/test_docs_workflow.py tests/test_docs_build_config.py tests/test_platforms.pypython scripts/check_source_size.pyruff check src/ tests/andruff format --check src/ tests/pre-commit run --files <changed files>(ruff, ruff format, typos, baretype: ignore)mypytach checkpytest -x -qThe Relock job verified the new lock on Linux/3.12 before its branch existed: PyPI-only hosts,
uv sync --locked, ruff, the format check, mypy,tach, andpytest -q(13,692 passed, 27 skipped).After cherry-picking it, with opentelemetry-api 1.45.1 installed in the same environment. The
mypyand source-size hooks run throughuv run, which re-locks through this machine's mirror, so they ran directly:python scripts/check_lock_hosts.py uv.lockSKIP=mypy,source-size pre-commit run --files <changed files>mypy,python scripts/check_source_size.py,tach checkpytest -p no:tach tests/test_lockfile.py tests/test_ci_workflow.py tests/test_docs_links.py tests/test_docs_build_config.pypytest -n 8 -quv export --frozen --all-extras --no-emit-project --no-dev, thenuvx pip-audit -r <export> --disable-pipChecklist
make checkpasses locally.and a fail-closed audit entry, and sensitive reads are still masked.