Skip to content

[SLW] Remove assembly multi byte nops #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DeaTh-G merged 1 commit into from
Oct 13, 2026
Merged

[SLW] Remove assembly multi byte nops #273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Source/Sonic Lost World/Fixes/Graphics/Fix Parkour Trail Model.hmm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ WriteAsmHook
jbe loc_10072B3C
push esi
xor esi, esi
nop dword ptr [eax+eax]

loc_10072B00:
mov eax, [ecx+0x58]
Expand Down
7 changes: 0 additions & 7 deletions Source/Sonic Lost World/Fixes/Graphics/Fix Super Sonic Mouth Switching.hmm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@ WriteAsmHook
jb loc_10003B60
lea eax, dword ptr ds:[ecx-1]
mov ecx, eax
nop dword ptr ds:[eax+eax], eax

loc_10003B40:
movsx eax, byte ptr ds:[ebx+edx]
Expand All @@ -115,7 +114,6 @@ WriteAsmHook
mov ecx, dword ptr ss:[ebp-0x10]
cmp edx, ecx
jae loc_10003B7D
nop dword ptr ds:[eax+eax], eax

loc_10003B60:
movsx eax, byte ptr ds:[ebx+edx]
Expand Down Expand Up @@ -216,7 +214,6 @@ WriteAsmHook
bswap eax
sub eax, 1
je loc_10003C54
nop word ptr ds:[eax+eax], ax

loc_10003C40:
mov eax, dword ptr ds:[ebx+0x34]
Expand Down Expand Up @@ -304,7 +301,6 @@ WriteAsmHook
jbe loc_10003D2E
add ecx, 0x1F
mov edx, 0x20
nop dword ptr ds:[eax], eax

loc_10003D20:
mov al, byte ptr ds:[ecx+4]
Expand Down Expand Up @@ -390,7 +386,6 @@ WriteAsmHook
test eax, eax
je loc_10003E73
mov ebx, dword ptr ss:[ebp-8]
nop dword ptr ds:[eax], eax

loc_10003E10:
mov eax, dword ptr ds:[esi+8]
Expand Down Expand Up @@ -479,7 +474,6 @@ WriteAsmHook
test edx, edx
je loc_10003F11
sub edi, ecx
nop dword ptr ds:[eax], eax

loc_10003EE0:
mov al, byte ptr ds:[edi+ecx]
Expand All @@ -496,7 +490,6 @@ WriteAsmHook
lea esi, dword ptr ds:[ecx-1]
add esi, edx
sub edi, ecx
nop dword ptr ds:[eax], eax

loc_10003F00:
mov al, byte ptr ds:[esi+edi]
Expand Down
Loading