Repository navigation
fix(controlled-documents): confirm signatures of SSO accounts with an email code - #11143
Open
MichaelUray wants to merge 1 commit into
Open
MichaelUray wants to merge 1 commit into
MichaelUray wants to merge 1 commit into
Conversation
… email code The signature dialog re-authenticated the signer only with email and password via the account login. Accounts created through SSO have no password, so they could not approve, reject or submit controlled documents at all. The dialog now checks whether the account has a password. If it does not, the signer requests a one-time code that is sent to the email of the current account (existing loginOtp/validateOtp flow) and confirms the signature with it; accounts with a password keep the password confirmation. In both cases the dialog now also verifies that the credentials belong to the signed-in account. The verification is extracted into a small helper with unit tests, and the package test script is enabled. The password setting part of the issue is already covered on develop: accounts without a password are offered an email-confirmed password setup instead of the change-password form. Refs hcengineering#10183 Signed-off-by: Michael Uray <michaeluray@users.noreply.github.com>
MichaelUray
force-pushed
the
fix/controlled-doc-sso-signature
branch
from
October 19, 2026 06:42
4719267 to
b1f9b35
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #10183
Problem and change
The signature dialog re-authenticated the signer only with email and password via the account login. Accounts created through SSO have no password, so they could not approve, reject or submit controlled documents at all.
The dialog now checks whether the account has a password. If it does not, the signer requests a one-time code that is sent to the email of the current account (existing loginOtp/validateOtp flow) and confirms the signature with it; accounts with a password keep the password confirmation. In both cases the dialog now also verifies that the credentials belong to the signed-in account. The verification is extracted into a small helper with unit tests, and the package test script is enabled.
The password setting part of the issue is already covered on develop: accounts without a password are offered an email-confirmed password setup instead of the change-password form.
Tests
New unit tests
plugins/controlled-documents-resources/src/__tests__/signature.test.ts;testscripts added to the package so CI runs them. A self-hosted check needs an SSO-only account and a working mail service for the code: open a controlled document as that user and Submit/Approve → the dialog offers "Send code" and accepts the emailed code; a user with a password still gets the password prompt.Notes