Repository navigation
Make basicUnsafeIndexM strict in element for Storable - #576
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it does make sense to make indexing strict. There's no unevaluated thunk which we may want to preserve, we create new value in place. Similarly primitive vectors forces result of indexing. Judging from bug report GHC <9.12 was able to optimize overhead away. So we seems to be at edge of its ability. No point in making its work harder.
This PR also adds regression test for checking that index doesn't allocate with -O2 (sadly it does with -O1)
Fixes #570