4718 hls graph session restart kills threads belong to later sesion session#4719
Draft
soulomoon wants to merge 1 commit intohaskell:masterfrom
Conversation
soulomoon
added
the
performance
soulomoon
force-pushed
the
4718-hls-graph-session-restart-kills-threads-belong-to-later-sesion-session
branch
3 times, most recently
from
3337d35 to
61cf5e4
Compare
…ns in Hlint plugin
soulomoon
force-pushed
the
4718-hls-graph-session-restart-kills-threads-belong-to-later-sesion-session
branch
from
61cf5e4 to
315dc7a
Compare
soulomoon
added
flaky test
and removed
performance
Collaborator
|
I just found this again, is this ready for merge? At least the |
Collaborator
Author
Thanks for digging it up. This patch is not enough. and I traced it down, one of the thing we still need to do is that we should wait for the debouncer before we send the done signal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WordAround #4718
Fix the two problems that make hlint plugin flaky
runWithSignalto avoid sending the start signal without end signal, which would make hlint's tests flasky