Skip to content

H-6450: Reduce space around entity headers #8707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CiaranMn merged 4 commits into from
May 26, 2026
Merged

H-6450: Reduce space around entity headers #8707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d1c013c
reduce space around entity headers
CiaranMn May 7, 2026
cf74dcb
don't offset content of slide stack by height of back/forward/close b…
CiaranMn May 26, 2026
c85b604
restore zindex
CiaranMn May 26, 2026
67f6d96
Merge branch 'main' into cm/reduce-padding-on-entity-headers
CiaranMn May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/hash-frontend/src/pages/entities.page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ const EntitiesPage: NextPageWithLayout = () => {
}
/>
)}
<Typography variant="h1" fontWeight="bold" my={3}>
<Typography variant="h1" fontWeight="bold">
{pageTitle}
</Typography>
</Stack>
Expand Down
2 changes: 1 addition & 1 deletion apps/hash-frontend/src/pages/shared/entity/entity-header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ export const EntityHeader = ({
</Box>
</Stack>
{showTabs && entityPath && (
<Box mt={7.5}>
<Box mt={3}>
<EntityEditorTabs entityPath={entityPath} isInSlide={isInSlide} />
</Box>
)}
Expand Down
30 changes: 16 additions & 14 deletions apps/hash-frontend/src/pages/shared/slide-stack.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,20 +78,22 @@ const StackSlide = ({
onClose={onClose}
/>

{item.kind === "dataType" && (
<DataTypeSlide dataTypeId={item.itemId} replaceItem={replaceItem} />
)}
{item.kind === "entityType" && (
<EntityTypeSlide replaceItem={replaceItem} typeUrl={item.itemId} />
)}
{item.kind === "entity" && (
<EntitySlide
{...item}
entityId={item.itemId}
removeItem={removeItem}
replaceItem={replaceItem}
/>
)}
<Box sx={{ pt: 1, background: ({ palette }) => palette.common.white }}>
{item.kind === "dataType" && (
<DataTypeSlide dataTypeId={item.itemId} replaceItem={replaceItem} />
)}
{item.kind === "entityType" && (
<EntityTypeSlide replaceItem={replaceItem} typeUrl={item.itemId} />
)}
{item.kind === "entity" && (
<EntitySlide
{...item}
entityId={item.itemId}
removeItem={removeItem}
replaceItem={replaceItem}
/>
)}
</Box>
Comment thread
CiaranMn marked this conversation as resolved.
</Box>
</Slide>
);
Expand Down
22 changes: 12 additions & 10 deletions apps/hash-frontend/src/pages/shared/slide-stack/slide-back-forward-close-bar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,29 +22,31 @@ export const SlideBackForwardCloseBar = ({
<Box
sx={{
width: "100%",
position: "sticky",
position: "absolute",
top: 0,
background: ({ palette }) => palette.common.white,
display: "flex",
justifyContent: "flex-end",
pointerEvents: "auto",
pt: 1.5,
pr: 3,
zIndex: 2,
}}
>
<Box pl={3} pr={4} py={1.5} display="flex" justifyContent="space-between">
<Box display="flex" justifyContent="space-between" gap={1}>
Comment thread
cursor[bot] marked this conversation as resolved.
{(onBack ?? onForward) ? (
<Box display="flex" justifyContent="space-between" gap={1}>
{(onBack ?? onForward) ? (
<>
<Tooltip title="Back" placement="bottom">
<IconButton disabled={!onBack} onClick={onBack}>
<ArrowLeftIcon />
</IconButton>
</Tooltip>
) : null}
{onForward ? (
<Tooltip title="Forward" placement="bottom">
<IconButton onClick={onForward}>
<IconButton disabled={!onForward} onClick={onForward}>
<ArrowRightRegularIcon />
</IconButton>
</Tooltip>
) : null}
</Box>
</>
) : null}
<Tooltip title="Close" placement="bottom">
<IconButton onClick={onClose}>
<CloseIcon />
Expand Down
Loading