sdk like config gen algorithm - #1297
Draft
ansgarm wants to merge 6 commits into
Draft
Conversation
ansgarm
commented
Apr 21, 2026
ansgarm
commented
Member
- wip - AI generated
- simplify code
- expand GenerateResourceConfig parity coverage
Add nested and validator-group cases so framework behavior is easier to compare against SDKv2, and drop unneeded resource configuration from validator collection.
Decompose the main tftypes.Transform closure into named helpers (lookupSchemaNode, shouldDropAlwaysAbsentValue, applyValidatorRules), remove the function-pointer dispatch in favor of three direct rule applications mirroring the SDKv2 shape, and share configuredMembers between the keep-first and also-requires policies. Behaviour is preserved; all existing tests pass unchanged. Adds maintainer notes citing the SDKv2 algorithm as the source of truth and flagging the Number-zero rule as a deviation worth revisiting.
…e cost of slight duplication but improved readability. don't nest concepts into deep functions. inline functions that were only called once or made code harder to read. drop some sdkv2 behaviour that's not relevant to framework Co-Authored-By: Selena Goods <selena.goods@hashicorp.com>
ansgarm
force-pushed
the
sdk-like-config-gen-algorithm
branch
from
May 12, 2026 13:16
2ce64c2 to
c5979a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.