Cap Retry-After waits to RetryWaitMax in RateLimitLinearJitterBackoff - #296
Closed
Hashim1999164 wants to merge 1 commit into
Closed
Cap Retry-After waits to RetryWaitMax in RateLimitLinearJitterBackoff#296Hashim1999164 wants to merge 1 commit into
Hashim1999164 wants to merge 1 commit into
Conversation
A 429/503 Retry-After value could previously sleep longer than RetryWaitMax, which stalled clients that treat max as a hard ceiling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
RateLimitLinearJitterBackofftreatedRetry-Afteras an uncapped sleep. A 429 or 503 with a largeRetry-After(or a far-future HTTP-date) could stall the client longer thanRetryWaitMax.This caps that wait to
max, which is the value callers already pass fromClient.RetryWaitMax.DefaultBackoffis left unchanged because #283 already covers that helper.Related Issue
Fixes #295
How Has This Been Tested?
go test ./...go test -count=1 -run TestBackoff_RateLimitLinearJitterBackoff .Existing cases where
Retry-Afterwas larger thanmaxnow expect the cap. Added a 3600sRetry-Aftercase withmaxof 3s.