feat: support custom client config signing with self-owned Ed25519 key - #2
Open
hashbk wants to merge 2 commits into
Open
feat: support custom client config signing with self-owned Ed25519 key#2hashbk wants to merge 2 commits into
hashbk wants to merge 2 commits into
Conversation
Replace the hardcoded official public key with a self-generated one, and add CI workflow steps to sign custom.txt from Action Secrets. - Generate new Ed25519 key pair for custom.txt verification - Replace public key in src/common.rs - Add res/sign_custom.py script for signing config with Ed25519 - Add CI workflow steps to sign and place custom.txt for all platforms (Windows Flutter/Sciter, macOS, Linux Flutter/Sciter) - Include custom.txt in deb, rpm, and arch packages when present Required GitHub Secrets: - CUSTOM_CLIENT_PRIVATE_KEY: Base64-encoded 64-byte Ed25519 private key - CUSTOM_CLIENT_CONFIG: JSON string of custom client configuration
The Windows Flutter build step runs on PowerShell by default, bash `if [ -f ]` syntax causes a parser error. Switch to `if (Test-Path)` which is native PowerShell.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the hardcoded official RustDesk public key with a self-generated Ed25519 key pair, and add CI workflow steps to automatically sign
custom.txtfrom GitHub Action Secrets during the build process.Changes
src/common.rswith a new self-generated Ed25519 public keyres/sign_custom.pyfor signing custom client config with Ed25519 private keycustom.txtfor all platforms:custom.txtin deb, rpm, suse rpm, and arch packages when presentRequired GitHub Secrets
To use this feature, configure the following secrets in your repository:
CUSTOM_CLIENT_PRIVATE_KEYCUSTOM_CLIENT_CONFIG{"app-name":"MyDesk","default-settings":{"server":"my.server.com"}})Key Pair
rgvzRBBtKBZnTT6iL2zhpyKxrtyC0iSnZXIUshDcNs4=CUSTOM_CLIENT_PRIVATE_KEYsecretHow it works
CUSTOM_CLIENT_PRIVATE_KEYandCUSTOM_CLIENT_CONFIGfrom secretsres/sign_custom.pysigns the config JSON with the private keycustom.txtis placed alongside the executable in the build outputIf the secrets are not configured, the build proceeds normally without
custom.txt.