Efremov HW 2#86
Open
EfremovEvgeniy wants to merge 15 commits intohardcode-dev:masterfrom
Open
Conversation
added 15 commits
May 19, 2022 20:11
spajic
approved these changes
Jun 7, 2022
Collaborator
spajic
left a comment
spajic
left a comment
There was a problem hiding this comment.
Всё так, только не забывай разделять бенчмарк и профайл
| Я решил исправить эту проблему, оптимизировав эту программу. | ||
|
|
||
| ## Формирование метрики | ||
| Для того, чтобы понимать, дают ли мои изменения положительный эффект на быстродействие программы я придумал использовать такую метрику: количество память показанное memory_profiler на 30_000 строк |
Collaborator
There was a problem hiding this comment.
не совсем правильно
memory_profiler - это профилировщик, его нельзя использовать для замера памяти
так как само его использование увеличивает использование памяти
то есть надо всегда разделять два процесса - бенчмаркинг и профайлинг
| Вот какие проблемы удалось найти и решить | ||
|
|
||
| ### Ваша находка №1 | ||
| - memory_profiler на 30_000 строк показывал 3.78 гб аллоцированной памяти. |
| line.strip! | ||
| user_attrs = [] | ||
| line.split(',') do |col| | ||
| user_attrs << col if col.match /[[:upper:]]/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.