feat(ratewise): E10 單幣別整頁 fold 佈局 - #683
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
s123104
force-pushed
the
feat/e10-single-fold
branch
from
July 8, 2026 01:16
3bc2aa1 to
b2b1af4
Compare
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
|
✅ SEO 審計通過!所有 2026 標準驗證項目都符合要求。
|
- v1 fold 序重排:金額輸入+快速金額 → 交換 → 匯率結果卡(含加入歷史紀錄)錨定首屏底緣 - fold 預算以 --app-height(CSS fallback 100svh)計算,不用 100vh/dvh,webview 工具列不溢出 - 臺銀四價詳情卡與趨勢卡移至 fold 下方自然捲動區,趨勢載入策略與基準標註零變動 - 快速金額列隱藏門檻下移至 fold 矩陣外(micro/nano),歷史動作全梯次維持 min-h-11 觸控 - 趨勢查看 SEO 文案(幣別頁/首頁 HowTo、指南步驟與進階卡)同步改為捲動語意,杜絕 IA 漂移 - 新增 8 視口 e2e fold 合約矩陣與 v2 零捲動不回歸驗證,另存 v1/v2 截圖矩陣各 8 張 測試:vitest run 全綠(9214 tests);playwright desktop+mobile 126 passed;text-parity 差異申報僅 5 處文案改寫 Co-authored-by: Cursor <cursoragent@cursor.com>
s123104
force-pushed
the
feat/e10-single-fold
branch
from
July 8, 2026 01:39
b2b1af4 to
3baa233
Compare
Contributor
|
✅ SEO 審計通過!所有 2026 標準驗證項目都符合要求。
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
實作 E10 單幣別整頁 fold 佈局(v1 主戰場):PWA/行動瀏覽器首屏底界=「匯率結果卡(含加入歷史紀錄動作)」底緣,8 視口零捲動可見;四價詳情、趨勢卡、資訊區移至 fold 下方自然捲動。
Refs:
.claude/prds/single-converter-fold-design.md(E10 簡報 SSOT)Fold 合約說明
--app-height為 SSOT(index.htmlinline script/AppLayout JS 寫入visualViewport.height;CSS fallback 由100dvh改為100svh——webview 動態工具列下最保守可視高度,dvh 可能含宿主 UI 造成溢出)。查證:svh 為 Baseline 2022(Chrome 108+/Safari 15.4+/Firefox 101+),repo browserslistbaseline widely available涵蓋;Tailwind v3.4 原生支援 svh 單位(context7 官方文件確認)。min-h-[calc(var(--app-height,100svh)-80px-env(safe-area-inset-top))]撐滿首屏(80px=header 48+內容 pt 16+卡片 pt 16),內部pb 64px(slim ≤360px 92px,對齊 mainScroll token)抵銷固定底導覽;結果卡mt-auto錨定 fold 底緣;md:全部歸零(fix(ratewise): 平板 ≥1024 兩欄佈局適配(#594 二階) #643 兩欄無 fold 壓力)。視口矩陣結果(e2e
single-fold.spec.ts,全數通過)截圖矩陣:8 視口 × v1/v2 共 16 張存
screenshots/e10-fold-*.png(QA 暫存,未提交)。壓縮手段摘要(沿用既有 height-tier,零新斷點)
min-h-11(44px 觸控合約;原僅 micro/nano 有下限,360×740 實測 42px 已修正)。640px 極限實測(無需降級)
360×640(tiny)實測 fold 內容約 500px < 預算 560px,無需「結果卡單行摘要+展開」降級——快速金額列、交換鈕、完整結果卡與歷史動作全數零捲動可見(見
screenshots/e10-fold-v1-360x640-*.png)。降級提案保留為未來更小視口(<600px)選項,暫不實作。前置合約不回歸
converter-v2.spec.ts全綠+本 PR v2 8 視口零捲動斷言。SingleConverter分流器(two-pass render)零變動,改動僅在 legacy 元件內部。Test plan
pnpm --filter @app/ratewise exec vitest run全綠(192 files/9214 tests,含 feat(ratewise): E8 wave-A — v2 等值雙列功能補全第一波(快速金額/歷史寫入/方向翻轉/長按複製) #667/fix(ratewise): 修復 360px 底部留白死類與 v2 小高度視口鍵盤遮擋(#662、QA-J J-1) #675 守門與新增 fold 佈局單測)playwright test(chromium-desktop+chromium-mobile)126 passedpnpm build:ratewise+pre-commit/pre-push hooks 全過Made with Cursor