fix(ratewise): 內容頁錨點 safe-area 連動與修復 @font-face 被 Beasties 剝除 - #616
Merged
s123104 merged 1 commit intoJul 5, 2026
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Jul 5, 2026
s123104
pushed a commit
that referenced
this pull request
Jul 5, 2026
- generate-manifest 的 scope/start_url 改由 VITE_SITE_URL 環境變數驅動+trailing-slash 正規化, 未設定時回退 APP_INFO.siteUrl,committed manifest 預設輸出零 diff(已實證) - staging 等替代網域部署設 VITE_SITE_URL 即可脫離跨網域 scope,不硬編任何 staging 網域; id 維持 /ratewise/ 不破壞既有安裝更新連續性 - build-scripts 測試同步改斷言 env 驅動寫法;002 與 changeset 對齊 manifest 專用範圍 - 字體 @font-face 被 Beasties 修剪部分經 PM 裁決移交 #616(inlineFonts 方案)處理 測試:pnpm vitest run、pnpm typecheck、pnpm build:ratewise、 generate:deterministic 冪等+committed manifest 零 diff、verify:artifacts 通過 Co-authored-by: Cursor <cursoragent@cursor.com>
s123104
force-pushed
the
hotfix/content-nav-safe-area-h7
branch
from
July 5, 2026 21:27
aff889f to
c416914
Compare
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
|
✅ SEO 審計通過!所有 2026 標準驗證項目都符合要求。
|
s123104
pushed a commit
that referenced
this pull request
Jul 5, 2026
- generate-manifest 的 scope/start_url 改由 VITE_SITE_URL 環境變數驅動+trailing-slash 正規化, 未設定時回退 APP_INFO.siteUrl,committed manifest 預設輸出零 diff(已實證) - staging 等替代網域部署設 VITE_SITE_URL 即可脫離跨網域 scope,不硬編任何 staging 網域; id 維持 /ratewise/ 不破壞既有安裝更新連續性 - build-scripts 測試同步改斷言 env 驅動寫法;002 與 changeset 對齊 manifest 專用範圍 - 字體 @font-face 被 Beasties 修剪部分經 PM 裁決移交 #616(inlineFonts 方案)處理 測試:pnpm vitest run、pnpm typecheck、pnpm build:ratewise、 generate:deterministic 冪等+committed manifest 零 diff、verify:artifacts 通過 Co-authored-by: Cursor <cursoragent@cursor.com>
- 錨點 scroll-mt(隱私目錄、Guide 步驟、ContentSections)疊加 env(safe-area-inset-top) - sticky 列於 standalone 變高(PR 605)後,錨點跳轉不再被遮蔽(issue 600 連動項) - 品牌字體 @font-face 由 index.html 內嵌樣式移至 src/index.css(與 .brand-wordmark 同 sheet) - beastiesOptions 設 inlineFonts:true/preloadFonts:false,SSG 不再剝除 @font-face 與重複 preload - ContentPageLayout 補錨點斷言;index.html 測試改斷言 @font-face 居於 index.css 測試:vitest 3324 passed;typecheck 綠;build 綠;CDP inset 59px 錨點量測與 fonts.check 複驗通過 Co-authored-by: Cursor <cursoragent@cursor.com>
s123104
force-pushed
the
hotfix/content-nav-safe-area-h7
branch
from
July 5, 2026 22:04
c416914 to
edfe2ef
Compare
Contributor
|
✅ SEO 審計通過!所有 2026 標準驗證項目都符合要求。
|
s123104
pushed a commit
that referenced
this pull request
Jul 5, 2026
- generate-manifest 的 scope/start_url 改由 VITE_SITE_URL 環境變數驅動+trailing-slash 正規化, 未設定時回退 APP_INFO.siteUrl,committed manifest 預設輸出零 diff(已實證) - staging 等替代網域部署設 VITE_SITE_URL 即可脫離跨網域 scope,不硬編任何 staging 網域; id 維持 /ratewise/ 不破壞既有安裝更新連續性 - build-scripts 測試同步改斷言 env 驅動寫法;002 與 changeset 對齊 manifest 專用範圍 - 字體 @font-face 被 Beasties 修剪部分經 PM 裁決移交 #616(inlineFonts 方案)處理 測試:pnpm vitest run、pnpm typecheck、pnpm build:ratewise、 generate:deterministic 冪等+committed manifest 零 diff、verify:artifacts 通過 Co-authored-by: Cursor <cursoragent@cursor.com>
s123104
added a commit
that referenced
this pull request
Jul 5, 2026
- generate-manifest 的 scope/start_url 改由 VITE_SITE_URL 環境變數驅動+trailing-slash 正規化, 未設定時回退 APP_INFO.siteUrl,committed manifest 預設輸出零 diff(已實證) - staging 等替代網域部署設 VITE_SITE_URL 即可脫離跨網域 scope,不硬編任何 staging 網域; id 維持 /ratewise/ 不破壞既有安裝更新連續性 - build-scripts 測試同步改斷言 env 驅動寫法;002 與 changeset 對齊 manifest 專用範圍 - 字體 @font-face 被 Beasties 修剪部分經 PM 裁決移交 #616(inlineFonts 方案)處理 測試:pnpm vitest run、pnpm typecheck、pnpm build:ratewise、 generate:deterministic 冪等+committed manifest 零 diff、verify:artifacts 通過 Co-authored-by: haotool <haotool.org@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #600(safe-area 主修已由 #605 完成並併入 base;本 PR 保留 #600 的兩件獨有價值)
摘要
scroll-mt-20(固定 80px)不足,隱私頁目錄與使用指南步驟跳轉後被返回列遮蔽。三處(Privacy 目錄、Guide 步驟、ContentSections)改scroll-mt-[calc(5rem+env(safe-area-inset-top,0px))]。@font-face原在index.html內嵌樣式,Beasties 逐 sheet 判定 critical fonts 時因該 sheet 無使用者而整條剝除並注入重複 preload → 全站「unused preload」console warning、頁首 wordmark 永遠回落系統字體(正式站取證:HTML 無任何@font-face)。修法:@font-face移至src/index.css(與.brand-wordmark同 sheet)+ssgOptions.beastiesOptions = { inlineFonts: true, preloadFonts: false }。fix(ratewise): manifest 網域改由 VITE_SITE_URL 環境驅動 #613 縮窄為 manifest 專用,不再碰字體。錨點跳轉量測(CDP inset top 59px、390×844、build preview)
#overview#step-1(修復前
scroll-mt-20僅預留 80px,sticky 列實高 124px,target 會被壓在列下。)字體前後證據
修復前(正式站/staging 取證):
@font-face(剝除);同時被注入第二個 font preloadThe resource ...nunito-wordmark-900.woff2 was preloaded using link preload but not used within a few seconds...修復後(build dist + preview 驗證):
@font-face(URL 帶 base:/ratewise/fonts/nunito-wordmark-900.woff2)preloadCount === 1),字體請求 200document.fonts.check('900 16px "Nunito Wordmark"') === true(首頁與 FAQ 頁)與 #605 的分工
pt-[calc(0.625rem+env(safe-area-inset-top,0px))]與 8 條守門測試:由 fix(ratewise): 內容頁 sticky 返回列補 safe-area-inset-top 適配 #605 完成(已在 base,本 PR 零重複 hunk)ContentPageLayout.test僅保留錨點連動斷言,sticky 列斷言註記由PageNavHeader.safe-area.test.tsx守門附帶取證(沿用先前調查)
scope/start_url硬編正式站 URL,牽動 SSOT 生成鏈不硬修)審查收斂(APPROVE 後)
@font-face存活與 preload 單一化):已由 PM 立案 [debt] 字體 @font-face 防回歸缺 dist 層守門(Beasties 升版/設定移除即靜默復發) #621 後續處理,不在本 PR 範圍src/index.css過期註解「@font-face 定義於 index.html critical CSS」已刪除(與新現況矛盾)5b8c9b24(feat(ratewise): E5 wave-B 幣別/金額頁 UIUX 六段 IA 重構 #615),002 檔頭累計以 base +2 重算為 +149閘門
pnpm --filter @app/ratewise test:3324 passed / 2 skipped(含 fix(ratewise): 內容頁 sticky 返回列補 safe-area-inset-top 適配 #605 的 8 條 + 本 PR 錨點斷言)pnpm typecheck、pnpm build:ratewise:綠(rebase 後重跑)