fix(split-meow): 混幣行程顯示警告並停止跨幣別錯誤加總 - #449
Merged
Merged
Conversation
- 偵測 trip 內多幣別時隱藏單一總額與結算,改顯示警告(四語系) - 跨幣別直接相加 totalSpent/settlements 為無效運算,避免顯示誤導金額 - 分享文字同步以警告取代錯誤總額與結算 - 補 HistoryTab 混幣/單幣行程行為測試(Codex review Q3) 測試:split-meow typecheck 通過;vitest HomeAndHistorySmoke 19 tests 通過
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8d6d91c5e0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This was referenced Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
Codex 三方 review(Q3)發現 split-meow 的 production bug(已隨 #445 上線):當同一行程記到多種幣別(使用者在 Settings 中途切換全域幣別)時,
totalSpent/balances/settlements直接把不同幣別的數字相加,並以單一幣別標籤顯示——產生看似精準實則錯誤的總額與結算,Codex 評為「比沒有總額更糟」。修法(最小生產級安全修復)
isMixedCurrency(trip 內出現 >1 種幣別)。驗證
🤖 Generated with Claude Code