feat(split-meow): 每筆支出保存幣別與匯率快照,KRW 顯示對應 TWD - #443
Closed
s123104 wants to merge 2 commits into
Closed
Conversation
- ExpenseRecord 新增 currency 與 exchangeRateKrwPerTwd 快照欄位 - HistoryTab 依快照顯示幣別,KRW 支出附 TWD 換算副標 - 新增 formatKrwAsTwd 與對應單元測試 測試:split-meow typecheck 與 currencies、useStore vitest 全通過 Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fd146e2cc4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
摘要
收編 split-meow 每筆支出幣別快照功能至 baseline,向後相容。
變更
ExpenseRecord加 optionalcurrency+exchangeRateKrwPerTwd,記帳當下寫入快照formatKrwAsTwd嚴格 guard;歷史頁 KRW 列顯示≈ NT$測試
注意
governance-v2(stacked PR)🤖 Generated with Claude Code