116 RC Threshold Calibration - #131
Conversation
hannahvsawiuk
left a comment
hannahvsawiuk
left a comment
There was a problem hiding this comment.
Unsure about using FileSystem. I am pretty sure this creates a file within the Arduino's on board memory. Try this: https://electronics.stackexchange.com/questions/54/saving-arduino-sensor-data-to-a-text-file
| @@ -0,0 +1,100 @@ | |||
| #include<EEPROM.h> | |||
There was a problem hiding this comment.
pls format using Ctrl + Shift + I on vscode
|
|
||
| //**********Right Joystick**********// | ||
| //MAX Position | ||
| Serial.println("Please move the right joystick to the maximum position\n"); |
There was a problem hiding this comment.
can you specificy that the maximum position is up (like forwards)
| rc2 = pulseIn(rc_channel2, HIGH); | ||
| EEPROM.put(rc2_addr_max, rc2); | ||
| //MIN Position | ||
| Serial.println("Please move the right joystick to the minimum position\n"); |
There was a problem hiding this comment.
specify what the minimum position is
|
|
||
| //**********Switch A(Remote E-stop)**********// | ||
| //Position 0 | ||
| Serial.println("Please move Switch A to 0\n"); |
There was a problem hiding this comment.
we need to label these on the RC itself somehow
| int switchB = 7; //Channel 6 | ||
|
|
||
| //Address in EEPROM | ||
| const int rc2_addr_max = 0; |
There was a problem hiding this comment.
consider moving this pinout.h and use #define instead
There was a problem hiding this comment.
make this file pinout agnostic
There was a problem hiding this comment.
e.g.
#@file pinout.h
#define RC_CHANNEL2 3
#define RC_CHANNEL3 4There was a problem hiding this comment.
Further, the EEPROM addresses need to be in a header file (e.g. eeprom_io.h). This will need to be used by the main firware to read from these addresses. Don't define them as const ints in the scope of this program.
hannahvsawiuk
left a comment
hannahvsawiuk
left a comment
There was a problem hiding this comment.
See the comments I left.
| //**********Right Joystick**********// | ||
| //MAX Position | ||
| Serial.println("Please move the right joystick to the maximum position\n"); | ||
| delay(2000); |
There was a problem hiding this comment.
Don't use delays. I suggest doing something like the following:
- Indicate which measurement.
- Wait for a start character.
- Record the values for 5 seconds or until the stop character is sent. This gives the user a small window to move the joystic. Note: I would suggest checking the data rate so a bunch of data is stored and possible lost. Maybe 2 seconds is good. Throughout this period, keep sampling.
- Find the max/min from the collected data and save the value to the EEPROM
There was a problem hiding this comment.
I suggest creating a seperate function for this with a few arguments:
int get_threshold(const char * user_question, bool min = false, bool max = false, bool mean = false, uint8_t rc_pin, uint8_t eeprom_addr)
{
/*
1.print the string
2.wait for a start char
3.sample and store into a temp array
4.wait for time end or end char. Or, cancel char which exits the measurement and re-runs the question routine.
5.get min/max/mean
6.write value to eeprom
7.return true is successful data collection and eeprom write, else false
*/
}| int switchB = 7; //Channel 6 | ||
|
|
||
| //Address in EEPROM | ||
| const int rc2_addr_max = 0; |
There was a problem hiding this comment.
Further, the EEPROM addresses need to be in a header file (e.g. eeprom_io.h). This will need to be used by the main firware to read from these addresses. Don't define them as const ints in the scope of this program.
3 participants
No description provided.