Repository navigation
Re-take the entitlement-key reader from upstream 6.1.0 (HF-307) - #1844
Open
marcin-kordas-hoc wants to merge 1 commit into
Open
marcin-kordas-hoc wants to merge 1 commit into
marcin-kordas-hoc wants to merge 1 commit into
Conversation
…6.1.0 The reader in hyperformula/src/license/handsontable-license-key-parser/ is now upstream's vendor/entitlement-key-reader at tag 6.1.0. Between 5.1.1 and 6.1.0 only README.md changed in that directory, so the reader code, the one declared TypeScript 4.0 cast and HyperFormula's behaviour stay the same. The pin in upstream.json and the table in PROVENANCE.md name the new tag. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
hyperformula-docs | 6f0688b | Commit Preview URL Branch Preview URL |
Oct 25 2026, 02:00 AM |
Performance comparison of head (6f0688b) vs base (d143456) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1844 +/- ##
========================================
Coverage 97.28% 97.28%
========================================
Files 207 207
Lines 16218 16218
Branches 3556 3588 +32
========================================
Hits 15777 15777
Misses 433 433
Partials 8 8 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The PR re-takes the vendored entitlement-key reader from upstream tag 6.1.0.
driftcheck fails ondevelop. Every file still matches the pinned tag 5.1.1, and the only problem is that upstream has released 5.2.0, 6.0.0 and 6.1.0 since.hyperformula/src/license/handsontable-license-key-parser/):README.md: upstream's file at 6.1.0. It is the only file in upstream'svendor/entitlement-key-reader/that changed between 5.1.1 and 6.1.0.upstream.json: the pin names tag 6.1.0 and its commit.PROVENANCE.md: the table names the new tag.Upstream's 6.0.0 major release changes the key generator (prose templates, record fields, default schema), not the reader or the payload format.
How did you test your changes?
node hyperformula/script/check-license-key-parser-drift.js: 13 filesok, exit 0. With one byte added toREADME.md, it reports the difference and exits 1.developbranch ofhyperformula-tests, unchanged: 520 of 520 suites pass; 6742 tests pass, 3 skipped. No paired tests branch: no reader code changed.Compatibility with Excel and Google Sheets
Not applicable.
Public API changes
None.
Out of scope and follow-ups
hyperformula-testswere minted with license-key 5.1.1. They read the same with this reader, but their header says 5.1.1 is the version HyperFormula vendors.fun:*andfeat:*tokens. The 6.x generator accepts them. Reminting is a separate change.Types of changes
Related issues
Checklist
dev-docs/pages this change affects – or none needed it.🤖 Generated with Claude Code
Note
Low Risk
Documentation and upstream pin only; reader implementation unchanged, so license validation behavior should be identical.
Overview
Re-syncs the vendored entitlement-key reader with upstream
license-keytag 6.1.0 so the drift check passes again (newer tags existed while the pin still pointed at 5.1.1).Pin and provenance:
upstream.jsonandPROVENANCE.mdnow record tag6.1.0, commit824cfd4bc, andtaken_on2026-10-25. The single allowed local divergence inextractKeyData.ts(TypeScript 4.0 cast) is unchanged.Docs only:
README.mdis brought in from upstream 6.1.0—the only file that differed between 5.1.1 and 6.1.0 in that directory. Updates include HyperFormulafun:/feat:capability examples instead of legacyfunctions_*/spreadsheet, guidance thathasCapabilityis exact-match and that HyperFormula expandsfun:all,feat:all, and group tokens in its own registry, and a revisedlicense-keyCLI fixture command listing spec Example 1 tokens.Runtime: No
.tsreader changes; key parsing behavior is intended to stay the same.Reviewed by Cursor Bugbot for commit 6f0688b. Bugbot is set up for automated code reviews on this repo. Configure here.