Repository navigation
HF-131 (6/7): thrown exceptions name the cell (issue #444) - #1766
Open
marcin-kordas-hoc wants to merge 16 commits into
Open
marcin-kordas-hoc wants to merge 16 commits into
marcin-kordas-hoc wants to merge 16 commits into
Conversation
Reading a formula cell's value before it has been computed used to throw a bare Error with no way to identify which cell caused it — the literal complaint in issue #444, open since 2020-07-07. Both vertex classes that can throw this (ScalarFormulaVertex and ArrayFormulaVertex, sibling classes in the same file) had the identical defect. CellValueNotComputedError carries the address as a field rather than only in prose, and is re-exported from the package (import block, HyperFormulaNS static, and the bottom export block in src/index.ts) so a consumer can catch it by type, not just by parsing the message. The message itself interpolates numeric sheet/row/col rather than A1-style notation: neither vertex class has access to the sheetIndexMapping that A1-conversion requires, so the field is the deliverable, not the prose. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
|
Task linked: HF-131 Verbose and actionable formula error messages |
7 of 12 tasks
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit da37522. Configure here.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
hyperformula-docs | a95916b | Commit Preview URL Branch Preview URL |
Oct 23 2026, 07:21 AM |
Performance comparison of head (a95916b) vs base (ae97e21) |
…esses # Conflicts: # CHANGELOG.md
…ddresses # Conflicts: # CHANGELOG.md
…ddresses # Conflicts: # CHANGELOG.md
…ddresses # Conflicts: # CHANGELOG.md
Tobiadefami
reviewed
Sep 21, 2026
Tobiadefami
left a comment
Collaborator
There was a problem hiding this comment.
The implementation looks good.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
… verb Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## fix/hf-131-rootless-origin #1766 +/- ##
==============================================================
+ Coverage 97.38% 97.40% +0.01%
==============================================================
Files 207 207
Lines 16343 16349 +6
Branches 3630 3630
==============================================================
+ Hits 15916 15925 +9
+ Misses 419 416 -3
Partials 8 8
🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Context
The PR makes the error thrown for a formula cell read before it was computed name that cell. It is part 6 of 7 of HF-131, stacked on #1765, and fixes #444.
Error('Value of the formula cell is not computed.')orError('Array not computed yet.'), with no way to tell which cell it was.hyperformula/src/errors.ts:CellValueNotComputedErrorwith a read-onlyaddressand the address in its message.hyperformula/src/DependencyGraph/FormulaVertex.ts: the scalar and array formula vertices throw it.hyperformula/src/index.ts: exported by name and asHyperFormula.CellValueNotComputedError.instanceof CellValueNotComputedErrorandinstanceof Error, and its message readsValue of the formula cell (sheet = 0, row = 0, col = 0) is not computed.How did you test your changes?
fix/hf-131-issue-444-addresses, with the newunit/errors.spec.ts(4 tests, both vertex types).Compatibility with Excel and Google Sheets
Not applicable: no formula result changes.
Public API changes
CellValueNotComputedError(alsoHyperFormula.CellValueNotComputedError).Out of scope and follow-ups
None.
Types of changes
Related issues
Checklist
dev-docs/pages this change affects – or none needed it.