Fix scalar versus size(1) array incompatibility between numpy 1.x and 2.x - #38
Open
dhuppenkothen wants to merge 1 commit into
Open
Fix scalar versus size(1) array incompatibility between numpy 1.x and 2.x#38dhuppenkothen wants to merge 1 commit into
dhuppenkothen wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue #37. Key problem is that implicit conversion of 1D arrays to scalars now throws a TypeError (see release notes for numpy 2.4 here: https://numpy.org/devdocs/release/2.4.0-notes.html). the
.item()syntax extracts the relevant value from the array and passes this as a scalar instead.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested on the minimum example given in issue #37, on python 3.14 and numpy 2.4.