Skip to content

Improve comment widget accessibility and pagination state - #263

Merged
ruibaby merged 2 commits into
mainfrom
improvement/comment-widget-a11y
Nov 7, 2026
Merged

ruibaby merged 2 commits into
mainfrom
improvement/comment-widget-a11y

Conversation

@ruibaby

@ruibaby ruibaby commented Nov 2, 2026

Copy link
Copy Markdown
Member

Summary

Align the storefront comment widget with the Web Interface Guidelines and harden pagination and history behavior.

Changes

  • Accessibility
    • Use aria-pressed for upvote and aria-expanded for reply and reply-list toggles, with screen-reader labels.
    • Announce the comment count in a polite live region and show the empty state only after a successful load.
    • Give the quote badge an accessible name and keep it keyboard focusable.
    • Announce the loading state.
  • Interaction and history
    • Sync comment pagination with the comment-page URL parameter, including popstate.
    • Prevent in-flight responses from rewriting the URL after the widget is disconnected, and never inherit a stale push intent.
    • Warn before leaving with an unsaved draft.
    • Lazy-load images in comment content.
  • i18n
    • Update Spanish, Simplified Chinese, and Traditional Chinese translations and regenerate locale bundles.
  • Tooling
    • Bump the Halo dev server to 2.27.0 (matching plugin.yaml) and the plugin devtools to 0.9.0.

Testing

  • pnpm exec tsc --noEmit — passed
  • pnpm test — 36 files / 192 tests passed
  • pnpm build — passed
  • Manual E2E on Halo 2.27.0 with the Sakura theme: comment and reply submission, pagination URL and browser back, upvote, replies toggle, quote badge keyboard focus, lazy images.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-07T13:34:33.153775Z a0ebe48 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@ruibaby

ruibaby commented Nov 7, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: a0ebe487e2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ruibaby
ruibaby merged commit b8a4824 into main Nov 7, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant