Repository navigation
Fix oversized preview response headers - #60
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview responses include every allowed public API path in the Content-Security-Policy header. A large API catalog can exceed reverse-proxy response-header buffers and cause preview requests to return 502.
Move the variable-size policy into a CSP meta element at the start of the document head, before theme resources and scripts. Keep
sandbox allow-scriptsin the HTTP response header because meta-delivered CSP cannot enforce sandboxing. Apply this to both Console previews and token previews while preserving the complete API allowlist and token isolation.Ordinary previews locate the head insertion point using parser source positions and insert the policy into the original HTML. This preserves CSS-sensitive whitespace and leading newlines in
<pre>without reserializing the document. Six regression cases cover explicit and implicit heads, comments, quoted attributes, and script text containing a literal<head>.Regression coverage renders both preview types with 300 public API paths. Before the fix, the CSP header exceeds 16 KiB. After the fix, response headers remain below 1 KiB, every allowed path remains in the document policy, and Content-Length matches the rewritten UTF-8 body.
Validation:
git diff --checkpassed.<pre>newlines match the original document after the fix.