Skip to content

Fix trace State pane words bleeding across Stack/Memory/Calldata columns #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
halaprix merged 2 commits into from
Jul 31, 2026
Merged

Fix trace State pane words bleeding across Stack/Memory/Calldata columns #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5cc6cd
fix(web): stop trace stack/memory/calldata words bleeding across columns
halaprix Jul 31, 2026
3c21c7e
Merge branch 'master' into fix/trace-state-panes-overlap
halaprix Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions apps/web/e2e/trace.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,14 @@ test('the trace pane shows machine state at the cursor (X5)', async ({ page }) =
await expect(facts).toContainText('#6');
const stackHeading = await page.locator('[data-testid="trace-stack"] h3').textContent();
expect(stackHeading).toMatch(/Stack \([1-9]\d*\)/);

// Regression: a full 32-byte word must stay inside its own pane, never
// bleeding into Memory or Calldata beside it (missing `.ss-trace-panes`
// selector scoping once let long hex words render unclipped).
const stackPane = page.locator('[data-testid="trace-stack"]');
const paneRight = (await stackPane.boundingBox())!.x + (await stackPane.boundingBox())!.width;
const wordBox = await stackPane.locator('li code').first().boundingBox();
expect(wordBox!.x + wordBox!.width).toBeLessThanOrEqual(paneRight + 1);
});

test('step modes navigate the timeline by keyboard (X6)', async ({ page }) => {
Expand Down
15 changes: 4 additions & 11 deletions apps/web/src/app/app.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1463,13 +1463,6 @@ input[readonly] {
}

/* ===== Trace inspector ===== */
.ss-trace {
border: var(--ss-border);
border-radius: var(--ss-radius);
padding: var(--ss-space-2);
margin-top: var(--ss-space-2);
}

.ss-trace-scrub {
display: flex;
align-items: center;
Expand All @@ -1490,7 +1483,7 @@ input[readonly] {
margin-top: var(--ss-space-2);
}

.ss-trace h3 {
.ss-trace-panes h3 {
font-family: var(--ss-font-ui);
font-size: 0.72rem;
letter-spacing: var(--ss-tracking-label);
Expand All @@ -1499,7 +1492,7 @@ input[readonly] {
margin: var(--ss-space-2) 0 var(--ss-space-1);
}

.ss-trace ol {
.ss-trace-panes ol {
list-style: none;
margin: 0;
padding: 0;
Expand All @@ -1510,14 +1503,14 @@ input[readonly] {
border: var(--ss-border);
}

.ss-trace li {
.ss-trace-panes li {
display: flex;
gap: var(--ss-space-2);
padding: 1px var(--ss-space-1);
overflow: hidden;
}

.ss-trace li code {
.ss-trace-panes li code {
overflow: hidden;
text-overflow: ellipsis;
white-space: nowrap;
Expand Down