Skip to content

Install Compose in orbs with an existing Docker CLI - #1688

Merged
skyfallwastaken merged 1 commit into
add-heartbeat-remapperfrom
fix-orb-compose-install
Sep 6, 2026
Merged

skyfallwastaken merged 1 commit into
add-heartbeat-remapperfrom
fix-orb-compose-install

Conversation

@skyfallwastaken

Copy link
Copy Markdown
Member

Summary of the problem

Orb setup skipped Compose installation whenever Docker was already installed, leaving the development environment unusable.

Describe your changes

Check for the Compose plugin as well as Docker before skipping installation. This is the foundation of the heartbeat audit follow-up stack above #1686.

Screenshots / Media

Not applicable: backend-only changes.

Co-authored-by: Amp <amp@ampcode.com>
@greptile-apps

greptile-apps Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Updates the orb setup script to verify both the Docker CLI and Docker Compose plugin before skipping Docker installation.

  • Allows setup to install Compose when Docker is already present.
  • Reuses the existing Docker and Compose installation path.
  • Does not include the regression coverage required for changed functionality.

Confidence Score: 4/5

The condition is a small and plausible fix, but the explicit repository testing requirement must be satisfied before merging.

The changed branch addresses the missing-Compose scenario, but no automated check exercises an environment where Docker exists without the Compose plugin.

Files Needing Attention: .agents/setup

Important Files Changed

Filename Overview
.agents/setup Expands the Docker installation guard to check Compose availability, but lacks required regression coverage for the new branch.
Prompt To Fix All With AI
### Issue 1
.agents/setup:30
**Missing Setup Regression Test**

This adds setup behavior for the case where Docker exists without the Compose plugin, but the PR includes no regression test or CI coverage for that state. The repository requires tests whenever functionality is added or changed, so this requirement must be satisfied before merging.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Reviews (1): Last reviewed commit: "Install Compose when Docker is already p..." | Re-trigger Greptile

Comment thread .agents/setup
@skyfallwastaken
skyfallwastaken merged commit 38cfd30 into add-heartbeat-remapper Sep 6, 2026
15 checks passed
@skyfallwastaken
skyfallwastaken deleted the fix-orb-compose-install branch September 6, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant