Install Compose in orbs with an existing Docker CLI - #1688
Merged
Merged
Conversation
Co-authored-by: Amp <amp@ampcode.com>
Contributor
Greptile SummaryUpdates the orb setup script to verify both the Docker CLI and Docker Compose plugin before skipping Docker installation.
Confidence Score: 4/5The condition is a small and plausible fix, but the explicit repository testing requirement must be satisfied before merging. The changed branch addresses the missing-Compose scenario, but no automated check exercises an environment where Docker exists without the Compose plugin. Files Needing Attention: .agents/setup Important Files Changed
Prompt To Fix All With AI### Issue 1
.agents/setup:30
**Missing Setup Regression Test**
This adds setup behavior for the case where Docker exists without the Compose plugin, but the PR includes no regression test or CI coverage for that state. The repository requires tests whenever functionality is added or changed, so this requirement must be satisfied before merging.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1): Last reviewed commit: "Install Compose when Docker is already p..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the problem
Orb setup skipped Compose installation whenever Docker was already installed, leaving the development environment unusable.
Describe your changes
Check for the Compose plugin as well as Docker before skipping installation. This is the foundation of the heartbeat audit follow-up stack above #1686.
Screenshots / Media
Not applicable: backend-only changes.