Apply settings layouts in the Inertia resolver - #1672
Open
skyfallwastaken wants to merge 2 commits into
Open
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-01a05ac7-f05c-703d-aeff-a0bab3bcc184 Co-authored-by: Amp <amp@ampcode.com>
Contributor
Greptile SummaryThe PR centralizes the default settings layout stack in the client and SSR Inertia resolvers, removing repeated declarations from individual settings pages.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (2): Last reviewed commit: "Cover settings layouts in system tests" | Re-trigger Greptile |
Amp-Thread-ID: https://ampcode.com/threads/T-01a05ac7-f05c-703d-aeff-a0bab3bcc184 Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the problem
Settings pages each repeat the same module declaration to select the application and settings layouts. This makes page files responsible for a directory-wide convention.
Describe your changes
The Inertia client and SSR resolvers now apply the settings layout stack to pages under
Users/Settings/when they do not declare an explicit layout. The repeated declarations and unused layout module have been removed.Screenshots / Media
No visual changes.