Skip to content

Apply settings layouts in the Inertia resolver - #1672

Open
skyfallwastaken wants to merge 2 commits into
mainfrom
amp/settings-layout-convention-20260901
Open

Apply settings layouts in the Inertia resolver#1672
skyfallwastaken wants to merge 2 commits into
mainfrom
amp/settings-layout-convention-20260901

Conversation

@skyfallwastaken

Copy link
Copy Markdown
Member

Summary of the problem

Settings pages each repeat the same module declaration to select the application and settings layouts. This makes page files responsible for a directory-wide convention.

Describe your changes

The Inertia client and SSR resolvers now apply the settings layout stack to pages under Users/Settings/ when they do not declare an explicit layout. The repeated declarations and unused layout module have been removed.

Screenshots / Media

No visual changes.

@greptile-apps

greptile-apps Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR centralizes the default settings layout stack in the client and SSR Inertia resolvers, removing repeated declarations from individual settings pages.

  • Applies AppLayout and SettingsLayout to settings pages without an explicit layout.
  • Preserves explicit page-level layout overrides.
  • Adds system coverage for server rendering and client-side settings navigation.
  • Removes the obsolete shared layout module.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
app/javascript/entrypoints/inertia.ts Applies the default settings layout stack during client-side page resolution while preserving explicit layouts.
app/javascript/ssr/ssr.ts Mirrors the client resolver behavior during server-side rendering.
test/system/settings/profile_settings_test.rb Covers settings layouts in SSR output and after an Inertia client-side navigation.
app/javascript/pages/Users/Settings/layout.ts Removes the layout helper made obsolete by resolver-level defaults.

Reviews (2): Last reviewed commit: "Cover settings layouts in system tests" | Re-trigger Greptile

Comment thread app/javascript/entrypoints/inertia.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant