Soft-delete streak goals and fix backdated start date bug#121
Open
anscg wants to merge 3 commits into
Open
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Discardable) instead of permanently destroyed when a user sets a new goal or their streak breaks — preserving historyuser_idwith a partial index scoped to kept (non-discarded) records, allowing multiple historical goals per useruser.streak_goalassociation now scoped to.keptso it always returns the active goalRoot cause of the double-announcement bug (user 252)
Pegoku completed their 7-day goal on Apr 20, then immediately set a new 3-day goal. Because
started_onwas backdated to the streak start (Apr 14), the 3-day goal was already satisfied on creation. The next day whenreconcile_missed_daysran a freeze and calledcheck_goal_completion, it fired the announcement immediately.