Ensure loadAddons returns an array - #218
Open
otacke wants to merge 1 commit into
Open
Conversation
Contributor
|
This makes sense |
Contributor
Author
|
@arzola So this could be moved to "Verified by Community Maintainer"? Do you have the rights to do that already? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for your interest in contributing to H5P! 🎉
Please fill in the below sections to make your pull request:
What kind of change does this PR introduce?
Bug fix
What is the current behaviour?
The H5P framework interface requires the
loadAddonfunction to return an array (https://github.com/h5p/h5p-php-library/blob/cb64a1f3884408487c3178e31fc140f5d45ca165/h5p.classes.php#L110-L114). However, the current implementation will returnnullif the SQL query fails (h5p-wordpress-plugin/public/class-h5p-wordpress.php
Lines 861 to 873 in 2a60665
What is the new behaviour?
If the SQL query fails, an empty array will be returned (silently failing) to honor the interface.
PR Checklist
Before submitting, please confirm:
Read the contribution guidelines to get your pr accepted more quickly.