common/ssl_util: require OpenSSL >= 3.2 with a clear diagnostic - #602
Open
jumaho wants to merge 1 commit into
Open
common/ssl_util: require OpenSSL >= 3.2 with a clear diagnostic#602jumaho wants to merge 1 commit into
jumaho wants to merge 1 commit into
Conversation
ssl_init() passes the TPM primary storage key PIN to the libtpm2 provider via OSSL_PROVIDER_load_ex(), an OpenSSL 3.2+ API. On older OpenSSL the file fails to compile with a cryptic implicit-function-declaration error; add an explicit #error so the requirement is obvious. Loading the provider without the PIN is deliberately not offered as a fallback: it would defer a TPM auth failure to runtime for the exact password-protected storage hierarchy the PIN exists for. Assisted-by: Claude Code:claude-opus-4-8 Signed-off-by: Julian Horsch <julian.horsch@aisec.fraunhofer.de>
jumaho
marked this pull request as ready for review
July 21, 2026 10:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ssl_init()loads the libtpm2 provider viaOSSL_PROVIDER_load_ex()(added inOpenSSL 3.2) to pass the TPM primary-storage-key PIN through an
OSSL_PARAMarray. On OpenSSL < 3.2 that function is not declared, so
common/ssl_util.cfails to compile with an implicit-function-declaration error.
Add a build-time check that emits a clear
#errorstating the OpenSSL >= 3.2requirement, so the build fails with an obvious diagnostic instead of an obscure
compiler error.