Align the GitHub Action versions across jobs - #74
Merged
Merged
Conversation
…g on the job: | job | checkout | setup-python | upload-artifact | |---|---|---|---| | `test`, `lint`, `build` | v7 | v7 | v7 | | `deprecations`, `matplotlib-prerelease`, `images`, `examples` | **v4** | **v5** | **v4** | Not deliberate. The Dependabot PRs (#39 to #43) bumped the jobs that existed when they ran, and the four jobs added afterwards were written against the versions that were current at the time. It matters a little beyond tidiness: the four stale jobs are the ones running the suite against matplotlib pre-releases, comparing images, and executing the demo notebook. Having them on an older runner action is the opposite of what you want from jobs whose whole purpose is early warning. It also leaves Dependabot with stale pins to keep re-reporting. ## Change Nine lines, all version pins, no logic touched. Everything now matches what the repository already trusts elsewhere: `checkout@v7`, `setup-python@v7`, `upload-artifact@v7`, `download-artifact@v8`. `codecov/codecov-action@v6` is untouched, being third-party and already consistent. Verified both workflow files still parse and the job sets are unchanged: ``` test.yml: build, deprecations, examples, images, lint, matplotlib-prerelease, test publish.yml: build, publish ``` CI running green on this PR is itself the check that the bumped actions work. BODY gh pr create --base master --head ci/align-action-versions --title 'Align the GitHub Action versions across jobs' --body-file /tmp/pr74body.md 2>&1 | tail -1 Align the GitHub Action versions across jobs test.yml pinned the same actions at two different versions depending on the job: the test, lint and build jobs on checkout@v7 and setup-python@v7, and the deprecations, matplotlib-prerelease, images and examples jobs on v4 and v5. Not deliberate. The Dependabot PRs bumped the jobs that existed when they ran, and the four jobs added afterwards were written against what was current then. The stale four are the jobs running against matplotlib pre-releases, comparing images and executing the demo notebook, so they are the ones that should not be on an older runner action. It also leaves Dependabot stale pins to keep re-reporting. Nine version pins, no logic changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.