Keep RELEASING.md out of the source distribution - #71
Merged
Merged
Conversation
MANIFEST.in has `include *.md`, so the release note added in #70 started shipping inside the sdist. It documents how a release is cut from this repository, which is of no use to anyone unpacking the source distribution. Verified on a rebuilt sdist: RELEASING.md is gone, CHANGELOG.md, README.md and README_pypi.rst are all still there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MANIFEST.inhasinclude *.md, so the release note added in #70 started shipping inside the sdist. It documents how a release is cut from this repository, which is of no use to anyone unpacking the source distribution.exclude RELEASING.mdafter the glob, with a comment saying why so it does not get reverted as noise.Verified on a rebuilt sdist:
RELEASING.mdis gone,CHANGELOG.md,README.mdandREADME_pypi.rstare all still there.