Update notebooks in prep for PyCBC PR #5388 - #37
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyCBC PR #5388 drops support for
emcee_ptand bumps the emcee version to 3.x. That breaks several tutorials. This updates the tutorials in prep for 5388. It also fixes some typos in the text I noticed while checking these, and adds some lines to silence lal warnings.Note for the future TBD: Inference tutorial 5 needs to be updated. It currently downloads an inference emcee_pt file from my old account on Atlas. That still works for now as PyCBC still supports reading emcee_pt files, but this should be changed to using a more modern sampler and to not to download things from Atlas (which will reach EOL in ~year). Instead of downloading a previously completed inference file, we could probably change the tutorial to do a complete run itself as we have fast enough samplers and models now that it's not unreasonable to do that within a notebook. This should be done in a future update.