Finalise A/B test migration and drop @guardian/ab-core#15995
Open
DanielCliftonGuardian wants to merge 4 commits into
Open
Finalise A/B test migration and drop @guardian/ab-core#15995DanielCliftonGuardian wants to merge 4 commits into
@guardian/ab-core#15995DanielCliftonGuardian wants to merge 4 commits into
Conversation
DanielCliftonGuardian
added
the
maintenance
DanielCliftonGuardian
changed the title
@guardian/ab-core
DanielCliftonGuardian
changed the title
@guardian/ab-core
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
cemms1
approved these changes
May 29, 2026
Contributor
cemms1
left a comment
cemms1
left a comment
There was a problem hiding this comment.
This looks great! So nice to tidy up all this old code ✨
Let's make sure we double check this works as expected locally and on CODE before merging
| /* keep array multi-line */ | ||
| ]; | ||
|
|
||
| const shouldCollectMetricsForBetaTests = (userTestParticipations: string[]) => { |
Contributor
There was a problem hiding this comment.
shall we take the Beta out of this name?
Comment on lines
84
to
86
| const collectBetaTestMetrics = shouldCollectMetricsForBetaTests( | ||
| Object.keys(userBetaParticipations), | ||
| ); |
Contributor
There was a problem hiding this comment.
Suggested change
| const collectBetaTestMetrics = shouldCollectMetricsForBetaTests( | |
| Object.keys(userBetaParticipations), | |
| ); | |
| const collectTestMetrics = shouldCollectMetricsForTests( | |
| Object.keys(userBetaParticipations), | |
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Removes the old
@guardian/ab-core-basedAB testing framework and promotes the new framework as the canonical one.Why?
The
@guardian/ab-coreframework has been superseded by the new AB testing system. The old framework required DCR to manage MVT ID parsing, switch filtering, and participation tracking itself. The new framework removes all of that complexity from DCR. With both frameworks running in parallel for a transition period, this PR removes the old one and tidies up the remaining scaffolding.