Tweak chromatic CI logic#15994
Open
Jakeii wants to merge 4 commits into
Open
Conversation
Jakeii
added
maintenance
github-actions
Bot
removed
the
run_chromatic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Added an
ifto the chromatic step so now chromatic should run with these conditions:run_chromaticlabel is present, run the Chromatic step.Also have added
pnp-workspace.yamland the workflows themselves to the paths that require chromatic to run.Why?
Currently the chromatic check is skipping when it should not be, because it skips when the
run_chromaticlabel is present.See the second to last commit checks with no relevant files changes - skips successfully, then final commit where I added the workflows to the paths that require chromatic and it requires chromatic as expected.