Remove show key events filter#15990
Draft
williammead wants to merge 3 commits into
Draft
Conversation
williammead
added
the
maintenance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Removes "Show key events only" toggle. The toggle was implemented with a parameter called filterKeyEvents so all references to that have been removed as well.
The accompanying work needs to be carried out in Frontend which is currently still filtering the key events if the filterKeyEvents query parameter is true and sending the filterKeyEvents parameter to DCR. When this accompanying work is complete DCR should be merged and deployed followed as soon as possible by frontend.
N.B. the filterKeyEvents parameter has also been removed from DCR's test fixtures, which allows them to pass, but as a lot of them are generated when the gen-fixtures command is run the parameter will return unless Frontend is updated, hence the need for the deployments to happen together.
Why?
In reference to #13513. Not enough traffic used the feature as it has similar functionality to the key events carousel.
Screenshots