Make centre rule configurable in grid module#15951
Open
frederickobrien wants to merge 1 commit into
Open
Conversation
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
github-actions
Bot
removed
the
run_chromatic
frederickobrien
force-pushed
the
custom-centre-rules-in-grid-api
branch
from
acda072 to
c98180b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rejigs the
verticalRulesoption added to thegridmodule in #15760 so that its configurable to the nth child of the grid, rather than the first by default. This has come up while working on #15358 and #15922 and feels like a worthwhile change in its own right as the central rule is likely to align with different pieces of article furniture depending on the layout.As a proving ground this PR applies the new approach to the gallery layout, which was the first to adopt the new vertical rules approach in #15776.