A117: Ring Hash exit_idle behavior changes#549
Open
dfawley wants to merge 2 commits into
Open
Conversation
dfawley
force-pushed
the
ring_hash_exit_idle
branch
5 times, most recently
from
f7e6a0c to
b036491
Compare
dfawley
force-pushed
the
ring_hash_exit_idle
branch
from
b036491 to
05b91aa
Compare
Member
Author
|
This PR is ready for review now. |
ejona86
approved these changes
May 19, 2026
|
|
||
| This proposal makes two behavior changes: | ||
|
|
||
| 1. Ring Hash should enter the CONNECTING state when the channel requests it to |
| > It does not matter which IDLE endpoint is chosen; that is left up to the | ||
| > implementation to determine. | ||
|
|
||
| Using a randomized endpoint will ensure that load is distributed evenly |
Member
There was a problem hiding this comment.
Note: it will not be distributed based on the weight of the endpoint. But picks will still wake up higher-weighted backends soon thereafter, so this seems fine.
Member
Author
There was a problem hiding this comment.
Added a clarifying note. Let me know if this behavior is preferred or if we do want to take weights into account.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Abstract
Update the Ring Hash LB policy to create connections when expliictly requested
by the channel to do so, instead of ignoring the request.