Skip to content

xds: fix ext_authz unit test issues creating import issues - #13061

Merged
sauravzg merged 1 commit into
masterfrom
dev/sauravzg/extauthz-test-fixes
Sep 17, 2026
Merged

sauravzg merged 1 commit into
masterfrom
dev/sauravzg/extauthz-test-fixes

Conversation

@sauravzg

Copy link
Copy Markdown
Contributor

The fixes were created by patching the currently failing CL , making fixes and running blaze to fix tests and then moving the public changes out of it to this PR.

  • Remove anonymous AutoValue subclassing in test which triggers Error Prone. While this decreases statistical test coverage, the branch is defensive programming that cannot occur in production.
  • Fix non-deterministic HashSet iteration order in CheckRequestBuilderTest.
  • Clean up and add explicit imports in test files.

- Remove anonymous AutoValue subclassing in test which triggers Error Prone.
  While this decreases statistical test coverage, the branch is defensive
  programming that cannot occur in production.
- Fix non-deterministic HashSet iteration order in CheckRequestBuilderTest.
- Clean up and add explicit imports in test files.
@shivaspeaks

Copy link
Copy Markdown
Member

Can you share the CL number?

@shivaspeaks
shivaspeaks self-requested a review September 15, 2026 18:41
@sauravzg

Copy link
Copy Markdown
Contributor Author

Can you share the CL number?

cl/980372016

@sauravzg
sauravzg merged commit fc56206 into master Sep 17, 2026
24 of 25 checks passed
@sauravzg
sauravzg deleted the dev/sauravzg/extauthz-test-fixes branch September 17, 2026 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants