ExperimentalAPI CLI#428
Open
timmarkhuff wants to merge 30 commits intomainfrom
Open
Conversation
…sdk into tim/experimental-cli
…sdk into tim/experimental-cli
| bound_method = getattr(gl, fake_method.__name__) | ||
| result = bound_method(*args, **kwargs) | ||
| if result is not None: | ||
| print(_format_result(result)) |
Collaborator
There was a problem hiding this comment.
Heavily biased as the one who wrote the original, but there should be more comments around this one line. This is the magic line that makes the whole thing happen
Contributor
Author
There was a problem hiding this comment.
Done. I added a comment.
|
|
||
| # Maps method names to their rich_help_panel group label for the CLI help output. | ||
| # Applies to both stable and experimental commands. | ||
| _COMMAND_GROUPS: dict[str, str] = { |
Collaborator
There was a problem hiding this comment.
I think this adds maintenance overhead, new methods need to belong to a group. The original design tried to avoid that additional overhead, but in the age of AI maybe we don't care
Contributor
Author
There was a problem hiding this comment.
I added a test to ensure that each method has a CLI group. It will be an extra step, but a worthwhile extra step that cannot be forgotten.
…sdk into tim/experimental-cli
…sdk into tim/experimental-cli
…sdk into tim/experimental-cli
…sdk into tim/experimental-cli
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExperimentalApimethods in CLIExperimentalApithat needed to be deprecated.