Skip to content

chore: English UI keys, catalog in reading order, specs archived, verify tools in CI - #56

Merged
grojof merged 2 commits into
mainfrom
chore/i18n-specs-ci
Oct 8, 2026
Merged

grojof merged 2 commits into
mainfrom
chore/i18n-specs-ci

Conversation

@grojof

@grojof grojof commented Oct 8, 2026

Copy link
Copy Markdown
Owner

Changes

  • i18n: ~20 Spanish labels still in the code (report headers, certificate states, purge summary, cert prompts, fail2ban/health messages) are now English keys with Spanish catalog entries. The catalog is written English → Spanish (it was Spanish → English and inverted at import, which silently merged 3 English strings whose Spanish matched). New tests, ported from odoo_dwg: every UI string has a Spanish entry (AST scan of t/tf/ask_*/choose/Command/render_table/level_text…) and no catalog key looks Spanish. 69 missing entries added.
  • Specs: the five merged changes (harden-data-operations, install-per-version, neutralise-copies, harden-operations, secrets-out-of-sight) archived into openspec/specs; seven placeholder purposes written.
  • Docs: no more workflows.py (now a package); layer tables list support.py and neutralise.py; the server-audit page quotes the English menu label; stale prompts.choose docstring.
  • CI: runs tools/verify_data_safety.py, tools/verify_secrets.py, tools/verify_ops_configs.py; under CI a skipped check fails. pythonpath = ["."] so pytest works without installing (e.g. uvx --from pytest pytest).

Verification

pytest 196 passed (also via uvx --python 3.12 --from pytest pytest); ruff and openspec validate --specs clean (16/16, no placeholder warnings); the three verify tools pass locally with CI=true.

Assisted-by: Claude

grojof added 2 commits October 8, 2026 13:24
…ify tools in CI

About twenty Spanish labels were still in the code; they are English keys
now, with their Spanish in the catalog. The catalog was written Spanish to
English and inverted at import, which silently merged English strings whose
Spanish matched; it is written English to Spanish now, and a test fails when
a UI string has no Spanish entry (the check odoo_dwg runs).

The five merged OpenSpec changes are archived into the specs, the seven
placeholder purposes are written, docs no longer name workflows.py and list
support.py and neutralise.py, and CI runs verify_data_safety, verify_secrets
and verify_ops_configs (a skip fails under CI).
@grojof
grojof merged commit 5d6ea03 into main Oct 8, 2026
1 check passed
@grojof
grojof deleted the chore/i18n-specs-ci branch October 8, 2026 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant