chore: Update readme and add more invalid dimensions checks - #71
Draft
ladipobaruwa-fn wants to merge 2 commits into
Draft
ladipobaruwa-fn wants to merge 2 commits into
ladipobaruwa-fn wants to merge 2 commits into
Conversation
ladipobaruwa-fn
commented
Oct 1, 2026
ladipobaruwa-fn
commented
Collaborator
- Adds documentation for new models (Stable Diffusion 3, HunyuanVideo 1.5, MiniMax-H3) and new workflow templates
- Input validation for dimension parameters
ladipobaruwa-fn
requested review from
FN-DiogoTeixeira,
alexfoundry and
omkar-foundry
and
a balanced review from Copilot
October 1, 2026 16:03
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Step validation remains incomplete, and the new user-visible constraints are not documented.
Review effort: Balanced
Findings: 1
Open (4)
What changed in this PR
Updates user documentation and strengthens latent-generation input validation.
Changes:
- Documents newly supported models and workflow templates.
- Validates denoising step configurations.
- Rejects non-positive latent dimensions and handles image/video frame counts correctly.
| File | Description |
|---|---|
README.md |
Expands supported-model and workflow-template lists. |
modular_diffusion_nodes_library/parameters/generate_latent_parameters.py |
Adds step-range validation. |
modular_diffusion_nodes_library/nodes/noise_latent_node.py |
Adds dimension validation and video-specific frame handling. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ladipobaruwa-fn
force-pushed
the
dipo/update_readme_and_invalid_dims
branch
from
October 1, 2026 16:19
e26745e to
b0dd314
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.