Skip to content

Consume network-modification-table renderers from commons-ui#3945

Open
flomillot wants to merge 1 commit into
perf/network-modifications-table-renderingfrom
perf/move-network-modification-renderers
Open

Consume network-modification-table renderers from commons-ui#3945
flomillot wants to merge 1 commit into
perf/network-modifications-table-renderingfrom
perf/move-network-modification-renderers

Conversation

@flomillot
Copy link
Copy Markdown
Contributor

Summary

The per-row cells, the `cell-renderers` adapter, the two services (`setModificationMetadata`, `updateModificationStatusByRootNetwork`) and the `@tanstack/react-table` module augmentation they relied on have moved to commons-ui.

  • Local files are deleted and `createColumns` now imports the renderers from `@gridsuite/commons-ui`.
  • `createRootNetworksColumns` is simplified: it only needs the root-networks list since the rest of the per-column meta (`rootNetwork`, `modificationsToExclude`, `isCurrentRootNetwork`, `currentRootNetworkTag`) is now derived from `TableMeta`.
  • The node editor passes `studyUuid`, `currentNodeId`, `currentRootNetworkUuid`, `rootNetworks`, `modificationsToExclude`, `setModificationsToExclude` and a combined `isDisabled` (`isAnyNodeBuilding || mapDataLoading`) to `NetworkModificationsTable`.
  • `gridstudy-app/src/module-tanstack.d.ts` is removed; the augmentation lives in commons-ui.

Companion PR on commons-ui: https://github.com/gridsuite/commons-ui/pulls?q=is%3Apr+head%3Aperf%2Fmove-network-modification-renderers

The per-row cells, the cell-renderers adapter, the two services
(setModificationMetadata, updateModificationStatusByRootNetwork) and the
@tanstack/react-table module augmentation that they relied on have moved
to commons-ui. Local files are deleted and createColumns now imports the
renderers from commons-ui. createRootNetworksColumns is simplified: it
only needs the root-networks list since the rest of the per-column meta
(rootNetwork, modificationsToExclude, isCurrentRootNetwork,
currentRootNetworkTag) is now derived from TableMeta. The node editor
passes studyUuid, currentNodeId, currentRootNetworkUuid, rootNetworks,
modificationsToExclude, setModificationsToExclude and a combined
isDisabled (isAnyNodeBuilding || mapDataLoading) to NetworkModificationsTable.

Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 13, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0129ff02-af28-452f-bb96-1695faaed10d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant