Repository navigation
Use organization slugs in Console handoffs - #1101
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughConsole organization routes and billing destinations now use validated organization-name slugs, while numeric IDs remain in use for authorization and service operations. Management flows compare requested path slugs with resolved organization names. Organization creation resolves the route name before setting organization context. ChangesOrganization slug handoff
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant ProfileRoute
participant ManagePage
participant currentConsoleOrganization
participant read
ProfileRoute->>currentConsoleOrganization: organization ID and return-path slug
ManagePage->>currentConsoleOrganization: organization ID and return-path slug
currentConsoleOrganization->>read: read organization by ID
read-->>currentConsoleOrganization: organization record and name
currentConsoleOrganization-->>ProfileRoute: accept or reject slug match
currentConsoleOrganization-->>ManagePage: accept or reject slug match
Merge Risk: ⚪ Minimal · up to No confirmed issue blocks the slug-based Console handoffs. Pre-merge checks |
  |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 9 functions across 11 files. (2 skipped: 2… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (4 passed)
-
Check name Status Explanation Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Title check The title clearly and concisely describes the main change: Console handoffs now use organization slugs. Description check The description directly explains the slug-based Console billing and management handoff changes, authorization behavior, validation rules, and test coverage.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 9 functions across 11 files. (2 skipped: 2 unsupported.)
- Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
-
📝 Generate docstrings 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
6 Skipped Deployments
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Console billing and management handoffs now use the organization's current unique name in
/organizations/{slug}/...URLs. Permanent organization IDs remain the service API and authorization identity; management pages and form returns recheck that the locator belongs to the same current member/owner-authorized organization.Numeric-only names remain valid slugs, without numeric-ID fallback or old-name redirects. No database migration, auth-provider change, billing policy or AI execution change.
Validation: all 480 Platform consumer tests pass, editor typecheck passes, formatting/lint hooks pass, and the real production-mode API pipeline passes all 386 HTTP cases. Its isolated build inventory includes the destination module consumed by the billing adapter. Coverage includes current billing/upgrade/purchase links, shared destination grammar and mismatched slug/ID rejection before mutation.