Repository navigation
Download a run's outputs as one zip from the viewer - #88
Merged
Merged
Conversation
A run's outputs could only be saved one file at a time. The workflow's details now offer Download all (.zip) above its outputs. - Each file is named as the run folder's outputs/ names it (store.md §8 "Names"): `<name><suffix>` for an output that is one file, `<name>/<label><suffix>` for each file of any other, long segments cut as the run folder cuts them. The archive is named after the run, and files are stored uncompressed. - The bytes come from the viewer's artifact URLs, and each file is checked against its recorded size and SHA-256 before it goes in. Files the viewer cannot serve are left out, and the details say how many. - One vanilla class in fx-web builds it with fflate (MIT, no dependencies, bundled so installed viewers stay offline); the viewer only mounts it. - An archive over 2 GiB, or one the tab cannot hold, fails with an error that says so; each output's own link still saves it. - The viewing guide and AGENT_READINESS say so: a viewer-only convenience, with --deliver and export covering the job for agents. The website's showcases do not offer it: a zip of a recording's outputs does not help a visitor. #87 records the idea that replaces it. Closes #82.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A run's outputs could only be saved one file at a time. The workflow's details in the viewer now offer Download all (.zip) above its outputs.
outputs/names it (store.md §8 "Names"):<name><suffix>for an output that is one file,<name>/<label><suffix>for each file of any other, long segments cut as the run folder cuts them. The archive is named after the run; files are stored uncompressed.web/fx-web(outputs.ts) with fflate 0.8.3 (MIT, no dependencies, bundled so installed viewers stay offline); the React viewer only mounts it.--deliverandexportcover the job for agents.The website's showcases do not offer it: a zip of a recording's outputs is not helpful to users today. #87 records the idea that replaces it.
bun.lockalso brings two stale workspace versions (0.5.0) up to the packages' 0.6.0.Checked
outputs.test.ts: names (single file, list, keyed collection, keys with/and.., suffix not doubled, long segments), omitted files, a later file replacing an earlier one at a name, digest and HTTP failures, the size limit refused before any read, the controller.coldviewer fixture holds the same 20 names and bytes as itsoutputs/; a scratch run with 300-character, non-ASCII and//..keys matches the engine's names too.cold.zipwith all 20 files.test:viewer152/152,check:viewer,build:viewer,check:www,test:www94/94,cargo test -p grida-fx-viewer,tools/check_viewer.py.Closes #82.