Skip to content

Clarify rule GCI9 "no-import-all-from-library" - #112

Merged
utarwyn merged 3 commits into
green-code-initiative:mainfrom
mhammed21:feature/warning-no-import-all-from-library
Jul 19, 2026
Merged

Clarify rule GCI9 "no-import-all-from-library"#112
utarwyn merged 3 commits into
green-code-initiative:mainfrom
mhammed21:feature/warning-no-import-all-from-library

Conversation

@mhammed21

Copy link
Copy Markdown
Contributor

ticket : #94

@MP-Aubay MP-Aubay left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix and test ok, could you update the CHANGELOG.md file and add a test example in test-project ?

@MP-Aubay MP-Aubay moved this from Backlog to In Progress in Hackathon kanban - JS/TS May 20, 2026
@utarwyn
utarwyn force-pushed the feature/warning-no-import-all-from-library branch from 4f6fe69 to f09a3a7 Compare July 19, 2026 09:13
@utarwyn utarwyn changed the title fix(no-import-all-from-library): allow named imports from forbidden l… Clarify rule GCI9 "no-import-all-from-library" Jul 19, 2026

@utarwyn utarwyn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello 👋
I took the liberty of making a few changes to make the rule crystal clear. Ultimately, the way it works didn't need to be changed, as explained in this comment.

Thanks for your work!

@utarwyn
utarwyn dismissed MP-Aubay’s stale review July 19, 2026 09:17

new commits have been pushed

@utarwyn
utarwyn merged commit faf20b8 into green-code-initiative:main Jul 19, 2026
2 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Hackathon kanban - JS/TS Jul 19, 2026
@utarwyn utarwyn linked an issue Jul 19, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

Clarify the rule "no-import-all-from-library"

3 participants