keyName - if this is not ObjectId it silently fails - #88
Merged
Conversation
…ame-different-than-objectId Verified that partitioning works with any key type not only _id Fixed DELETE events with custom partition key by adding fullDocumentBeforeChangeKey Added tests Updated README
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR successfully extends the library to support custom partition keys beyond ObjectId types. The implementation correctly addresses DELETE event handling by adding fullDocumentBeforeChange support to the partition matching logic. The comprehensive test suite validates String/Integer keys, partition consistency, and edge cases. Documentation clearly explains the new requirements for DELETE events with custom keys. No blocking issues found.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
witang9
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verified that partitioning works with any key type not only _id
Fixed DELETE events with custom partition key by adding fullDocumentBeforeChangeKey
Added tests
Updated README