Additional unit tests - ChangeStreams and ConfigManager - #63
Merged
Conversation
kkujaw
commented
Oct 15, 2024
kkujaw
commented
- Needs verification if feasible and logically correct
- 2 tests potentially failing - need consultation
- Also, not sure whether formatting changes are needed - I used the checkstyle settings
… failing need consultation
kkujaw
changed the title
kkujaw
marked this pull request as draft
October 15, 2024 19:03
kkujaw
marked this pull request as ready for review
October 17, 2024 07:13
kkujaw
changed the title
…t-coverage # Conflicts: # src/test/java/com/gravity9/mongocse/ConfigManagerTest.java
Remove duplicate definition of givenNewConfigWithDifferentNumberOfPartitions_shouldThrowException() that was causing compilation to fail. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.