Repository navigation
fix: keep sideEffects in esm/package.json - #113
Merged
Merged
Conversation
Contributor
|
Preview is ready. |
korvin89
marked this pull request as draft
November 2, 2026 11:12
korvin89
marked this pull request as ready for review
November 2, 2026 11:13
amje
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 2.22.1 (#108) the build generates
esm/package.jsonwith onlyversionandtype. esbuild readssideEffectsfrom the nearestpackage.json, so it no longer sees the root"sideEffects": falseand keeps every icon module inesm/. Each one leaves itsimport * as React from 'react'in the bundle.Only esbuild is affected. Vite 7 (Rollup) and webpack 5 already keep a single module.
Fix: repeat the root field in the generated file, as uikit does in its gulpfile:
Numbers
esbuild 0.25.12,
import {ArrowRotateLeft} from '@gravity-ui/icons',bundle,minify,format: 'esm',external: ['react']. Icon modules counted withbytesInOutput > 0inmetafile.outputs:Verification
npm run build:esm/package.jsonis{"version":"2.23.0","type":"module","sideEffects":false}. Rootpackage.jsonand the CJS output are byte-identical to a build ofmain.esm/package.jsonis the only file inesm/that changes.npm run lint,npm run typecheck: pass.npm pack --dry-run:esm/package.jsonis included.