Skip to content

fix(startup): stop logs claiming a random selection fallback - #483

Open
MoonBoi9001 wants to merge 6 commits into
mainfrom
mb9/stop-startup-logs-claiming-random-selection
Open

MoonBoi9001 wants to merge 6 commits into
mainfrom
mb9/stop-startup-logs-claiming-random-selection

Conversation

@MoonBoi9001

@MoonBoi9001 MoonBoi9001 commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

IISA has had no random selection mode since #49, so its startup logs now say what happens instead: without loadable scores it refuses selections with a 503, and a failed initialisation stops startup, logged once with its traceback. It also gives 2 test fixtures the current time as their computed_at, since their fixed 12 November date made those scores critically stale from the 19th and failed a test that counts error lines.

The selection-record and sync-claim fixtures pinned computed_at to 12 November, so from the 19th
IISA logged their scores as critically stale and a test counting error lines failed. They now
use the current time.
IISA has no random selection mode: without scores it answers selections with a 503, and a failed
initialisation stops startup. The startup warnings and a docstring now say so.
@MoonBoi9001
MoonBoi9001 added this pull request to stack #485 November 20, 2026 11:19
When IISA could not set up its score loader it logged 2 error lines with only the error's text,
so the cause could not be traced. It now logs 1 error with the full traceback before stopping.
The startup warning also covers a scores file that exists but can't be read or used, so saying
none was found sent the reader looking for a cache that was never written.
The 2 new startup tests read the token and log level settings from whatever the shell running
them had set, so a developer's own settings could fail them. They now clear those first.
A comment in the weighted scores test had been shortened outside this branch's purpose, losing
its note that each chain's score includes the price. It is back as it was.
@MoonBoi9001
MoonBoi9001 marked this pull request as ready for review November 20, 2026 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant