Repository navigation
fix(startup): stop logs claiming a random selection fallback - #483
Open
MoonBoi9001 wants to merge 6 commits into
Open
MoonBoi9001 wants to merge 6 commits into
MoonBoi9001 wants to merge 6 commits into
Conversation
The selection-record and sync-claim fixtures pinned computed_at to 12 November, so from the 19th IISA logged their scores as critically stale and a test counting error lines failed. They now use the current time.
IISA has no random selection mode: without scores it answers selections with a 503, and a failed initialisation stops startup. The startup warnings and a docstring now say so.
When IISA could not set up its score loader it logged 2 error lines with only the error's text, so the cause could not be traced. It now logs 1 error with the full traceback before stopping.
The startup warning also covers a scores file that exists but can't be read or used, so saying none was found sent the reader looking for a cache that was never written.
The 2 new startup tests read the token and log level settings from whatever the shell running them had set, so a developer's own settings could fail them. They now clear those first.
A comment in the weighted scores test had been shortened outside this branch's purpose, losing its note that each chain's score includes the price. It is back as it was.
MoonBoi9001
marked this pull request as ready for review
November 20, 2026 11:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IISA has had no random selection mode since #49, so its startup logs now say what happens instead: without loadable scores it refuses selections with a 503, and a failed initialisation stops startup, logged once with its traceback. It also gives 2 test fixtures the current time as their
computed_at, since their fixed 12 November date made those scores critically stale from the 19th and failed a test that counts error lines.