docs: align log-store docs with [log_store] TOML and pin Rust 1.94.0 - #6724
Open
imitater-dou wants to merge 1 commit into
Open
imitater-dou wants to merge 1 commit into
imitater-dou wants to merge 1 commit into
Conversation
Signed-off-by: ADou <ikun3.1415927@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align log-store documentation with the real
[log_store]TOML config, and pin the README Rust prerequisite to the toolchain inrust-toolchain.toml.Repro (tip
6838f4e3cf36)Fake CLI flags in README / docs
README.mdLog Storage quick example uses--log-store-backend file/--log-store-file-dir.docs/log-store.mddocuments a full--log-store-*CLI surface andGRAPH_LOG_STORE_*env vars, plusretention_days/max_size.node/src/opt.rshas no--log-store-*flags (search forlog_store/log-store→ no matches).LogStoreSectioninnode/src/config.rsunder[log_store]in the TOML passed with--config(directory,retention_hours,url, …). See alsonode/resources/tests/full_config.toml.ELASTICSEARCH_*were removed in favor of[log_store].Fictional env vars in
docs/environment-variables.mdGRAPH_LOG_STORE_*. Code search forGRAPH_LOG_STOREhits only docs files, not runtime source.Rust pin mismatch
rustup install stable.rust-toolchain.tomlpinschannel = "1.94.0"(with a comment about the 1.95.0 regression).What changed
README.md: pin Rust to 1.94.0; replace fake--log-store-*example with a[log_store]TOML snippet +--config.docs/log-store.md: document TOML-only configuration (field table matchingLogStoreSection), fix retention toretention_hours, add migration notes from removed ES CLI (*: Expose subgraph logs via subgraph GraphQL #6278), update troubleshooting.docs/environment-variables.md: remove fictionalGRAPH_LOG_STORE_*list; point readers at[log_store]/ the Log Store guide.Docs-only; no runtime changes.