Repository navigation
fix: the anthropic provider stops asking for a temperature - #47
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current models removed the sampling controls and replaced them with output_config.effort, so the client raised before anything reached the network. It now sends adaptive thinking and effort: high, and streams, because thinking makes a request long enough to hit the client timeout.
temperature is gone from the provider protocol with it: one provider takes one and sets its own. Both now send the current request shape and drop whatever the far end names in its rejection, which covers an older model with no effort level and an older client that has never heard of one. Picking the shape from the model name means a table of model names
that is wrong the week after it is written.