Skip to content

Fix PHI bounding box label numbering to handle index gaps #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Adithyan-Dinesh-Trenser wants to merge 1 commit into
base: nightly
Choose a base branch
from
Open

Fix PHI bounding box label numbering to handle index gaps #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions extensions/ohif-gradienthealth-extension/src/utils/phiBoundingBoxMeasurementUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,16 +34,28 @@ export function addAutoPHIBoundingBoxToolLabeler(servicesManager) {
return;
}

const phiMeasurementsCount = measurementService.getMeasurements(
(m) => m.toolName === phiBoundingBoxToolName
).length;
const otherPhiMeasurements = measurementService.getMeasurements(
// Exclude the current measurement to avoid self-referencing during the add event
(m) =>
m.toolName === phiBoundingBoxToolName && m.uid !== measurement.uid
);

const usedIndices = new Set();
otherPhiMeasurements.forEach((m) => {
const match = m.label && m.label.match(/PHI Bounding Box (\d+)/);
if (match) {
usedIndices.add(parseInt(match[1], 10));
}
});

let nextIndex = 1;
while (usedIndices.has(nextIndex)) {
nextIndex++;
}

measurementService.update(
measurement.uid,
{
...measurement,
label: `PHI Bounding Box ${phiMeasurementsCount}`,
},
{ ...measurement, label: `PHI Bounding Box ${nextIndex}` },
true
);
}
Expand Down