[newchem-cpp] Replace SpeciesLUTFieldAdaptor with FieldAdaptorManager and SpeciesMultiView - #562
Open
mabruzzo wants to merge 20 commits into
Open
[newchem-cpp] Replace SpeciesLUTFieldAdaptor with FieldAdaptorManager and SpeciesMultiView#562mabruzzo wants to merge 20 commits into
SpeciesLUTFieldAdaptor with FieldAdaptorManager and SpeciesMultiView#562mabruzzo wants to merge 20 commits into
Conversation
mabruzzo
force-pushed
the
ncc/SpeciesFieldAdaptor
branch
from
June 23, 2026 15:36
e1d601d to
2ed79c3
Compare
mabruzzo
changed the title
SpeciesLUTFieldAdaptor with FieldAdaptorManager and SpeciesMultiViewSpeciesLUTFieldAdaptor with FieldAdaptorManager and SpeciesMultiView
All changes in this commit are a search-and-replace (plus some automated reformatting since the number of characters is changing)
mabruzzo
marked this pull request as draft
July 23, 2026 14:31
This is inadvisable, but will be necessary to achieve reasonable performance in step_rate_newton_raphson
mabruzzo
force-pushed
the
ncc/SpeciesFieldAdaptor
branch
from
July 23, 2026 20:52
9eb8599 to
9fb8034
Compare
mabruzzo
marked this pull request as ready for review
July 24, 2026 14:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR depends on changes from #561
NOTE: This PR needs to rebased atop the more recent version of #561 (the more recent version includes changes from #575)
This PR introduces
FieldAdaptorManagerandSpeciesMultiView:SpeciesMultiView<T>is just an alias forMulti1DView<T>(introduced in PR [newchem-cpp] IntroduceMulti1dView#561)Multi1DView<T>in a few other places and using the type alias will make it easy for us to change the definition forSpeciesMultiView<T>(e.g. if we, as we've discussed before, ever decide to copy the species values into a temporary contiguous 2d array)FieldAdaptorManageris a tool that actually facilitates the creation of aSpeciesMultiViewfrom agrackle_field_datapointerIn order to avoid making this PR too big, I have primarily focused on just using this new machinery to replace the old, very hacky
SpeciesLUTFieldAdaptormachinery